feat: add imports to h2 MM supply benchmark#604
Merged
AndreasHD11 merged 14 commits intomasterfrom Apr 23, 2026
Merged
Conversation
tgilon
reviewed
Apr 3, 2026
Member
tgilon
left a comment
tgilon
left a comment
There was a problem hiding this comment.
Thank you @AndreasHD11 for this PR! It's a nice added value to the nodal benchmarks.
- I would suggest using a vectorized approach to clean the dataframe.
- Could you add a release note to the PR?
- Could you also add this PR to the list in the README and in
doc/index.rst
Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
for more information, see https://pre-commit.ci
* doc: prepare release v0.6.1 * doc: bump version * [github-actions.ci] Update locked envs * fix: fix typo * doc: update figures to v0.6.1 --------- Co-authored-by: tgilon <22521851+tgilon@users.noreply.github.com>
Member
Author
|
merged conflicts need to be changed. I will do this today |
AndreasHD11
force-pushed
the
feat/h2-supply-benchmark
branch
from
998f4f1 to
441b711
Compare
Member
Author
|
tgilon
reviewed
Apr 21, 2026
Member
tgilon
left a comment
tgilon
left a comment
There was a problem hiding this comment.
Thank you @AndreasHD11 for the updates! I have two comments:
- There is a line that seems to have been lost in the merge
- There is an issue with the bus naming convention
Other than that, it's really minor comments.
Member
Author
|
With fixed H2 |
tgilon
approved these changes
Apr 22, 2026
Member
tgilon
left a comment
tgilon
left a comment
There was a problem hiding this comment.
Amazing, thank you @AndreasHD11 !
Co-authored-by: Thomas Gilon <thomas.gilon@openenergytransition.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #551
Changes proposed in this Pull Request
This PR proposes to add hydrogen imports (ammonia and imports) from the Market Model Outputs data to the benchmarking.
Tasks
Workflow
Open issues
Notes
Test workflow locally run (2013 cy years etc..). Version (0.5.1) on plot comes from test config being run.
2040 csv benchmark:
2040 eu27 hydrogen supply plot:
2030 DE hydrogen supply plot:
Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.doc/configtables/*.csv.config/test/*.yaml.pixi run -e open-tyndp tyndp-cyears-test).doc/*.rstfiles.doc/release_notes.rstis added.READMEanddoc/index.rst.